Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glade/oscplot: Fix runtime GTK3 warning when creating plot #524

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

dNechita
Copy link
Contributor

PR Description

Get rid of GTK3 runtime warning each time an iio-osc plot is being created.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have followed the coding standards and guidelines
  • I have conducted a self-review of my own code changes
  • I have commented new code, particulary complex or unclear areas
  • I have checked in CI output that no new warnings/errors got introduced
  • I have updated documentation accordingly (GitHub Pages, READMEs, etc)

The warning:
    (osc:17335): Gtk-WARNING **: 13:53:21.583: Content added to the action area of a dialog using header bars

The GtkDialogFileChooser that is being created via Glade has an built in GtkHeaderBar which has an action area where the 'Save' and 'Cancel' buttons are added. And this is not allowed, hence the above warning. The GTK2 version of the GtkDialogFileChooser didn't have a built in GtkHeaderBar.

The solution was to create in Glade a simple GtkDialog to which a GtkFileChooserWidget has been added. A GtkDialog does not have a built in GtkHeaderBar.

Signed-off-by: Dan Nechita <[email protected]>
@cristina-suteu cristina-suteu merged commit fb1f9e2 into libiio-v1-support Feb 18, 2025
2 of 4 checks passed
@cristina-suteu cristina-suteu deleted the fix-oscplot-runtime-warning branch February 18, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants