plugins/dac_data_manager.c: dynamically convert data for enabled channels. #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandraTrifan
requested review from
cristina-suteu,
dNechita and
mhennerich
as code owners
AlexandraTrifan
force-pushed
the
fix_dac_dma_8chan
branch
from
0422e9d to
e5d16df
Compare
dNechita
reviewed
Feb 10, 2025
AlexandraTrifan
force-pushed
the
fix_dac_dma_8chan
branch
from
e5d16df to
d70aede
Compare
dNechita
reviewed
Feb 13, 2025
dNechita
reviewed
Feb 13, 2025
…nels. Instead of assuming a connected device will only have a maximum of 8 DMA channels, add a mechanism to dynamically convert data for all enabled channels. Signed-off-by: AlexandraTrifan <[email protected]>
AlexandraTrifan
force-pushed
the
fix_dac_dma_8chan
branch
from
d70aede to
05033c2
Compare
dNechita
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Instead of assuming a connected device will only have a maximum of 8 DMA channels, add a mechanism to dynamically convert data for all enabled channels.
This can be reproduced with a setup of ADRV9009 and FMCOMMS8 with all 8 TX channels enabled. Loading any file with all channels enabled will display "Waveform loaded successfully" but the DMA output will be 0. Doing the same with only 4 TX channels enabled will work properly.
PR Type
PR Checklist