Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure the sizeof argument to calloc is the second argument. #496

Merged
merged 1 commit into from
Jun 7, 2024
Merged

make sure the sizeof argument to calloc is the second argument. #496

merged 1 commit into from
Jun 7, 2024

Conversation

nunojsa
Copy link
Contributor

@nunojsa nunojsa commented Jun 7, 2024 •
edited
Loading

PR Description

new versions of gcc want to enforce this

(cherry picked from commit 565cade)

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have followed the coding standards and guidelines
  • I have conducted a self-review of my own code changes
  • I have commented new code, particulary complex or unclear areas
  • I have checked in CI output that no new warnings/errors got introduced
  • I have updated documentation accordingly (GitHub Pages, READMEs, etc)

@nunojsa nunojsa requested review from dNechita, cristina-suteu and a team June 7, 2024 12:38
@tsailer @nunojsa
make sure the sizeof argument to calloc is the second argument.
9010653 
new versions of gcc want to enforce this

Signed-off-by: Thomas Sailer <[email protected]>
(cherry picked from commit 565cade)
Signed-off-by: Nuno Sa <[email protected]>
dNechita
dNechita approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@dNechita dNechita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thank you!

@dNechita dNechita merged commit e9cd186 into 2022_R2 Jun 7, 2024
7 of 12 checks passed
@dNechita dNechita deleted the staging/fix-compilation branch June 7, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dNechita dNechita dNechita approved these changes

@cristina-suteu cristina-suteu Awaiting requested review from cristina-suteu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nunojsa @dNechita @tsailer