Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overal visual changes #12

Open
wants to merge 8 commits into
base: Version-1.3
Choose a base branch
from

Conversation

rmaalmeida
Copy link

Visual changes to version 1.3

  • ligthter colors,
  • run/stop buttons sunken when pressed
  • changed order of buttons on the bottom

Visual changes to version 1.3
- ligthter colors,
- run/stop buttons sunken when pressed
- changed order of buttons on the bottom
Refator most of the main screen widgets variable and change the visuals for a flat option
@damercer
Copy link
Contributor

damercer commented Oct 3, 2020

Thanks for suggesting these changes.

Since the default colors can (should be changed) by users in the alice_init.ini your suggested color changes will not be included as the defaults in master source code. User by user preferences can not be accommodated in the official release packages.

The other visual changes will be considered.

Changes to widget locations in the UI screens are problematic in that it will require all the graphics in the User Guides be changed and possibly confuse existing users and force users to likely require changes to Lab documents.

…lice into Version-1.3"

This reverts commit 08985de, reversing
changes made to 0897240.
Implemented a simple interface version with only scope, XY and analog wave generator. All advanced controls are disabled. AWG and Scope are on the same screen.
@damercer
Copy link
Contributor

damercer commented Oct 9, 2020

Hi:
Please remember you are submitting pull request that fundamentally change the master copy of the source code through this means. If you just want to show the developers some personal changes you have made, then post a plain issue listing the changes / enhancements that you are suggesting, and include a link to your personal copy of the source code.

I can't merge pull requests like these (with the same name as the "golden" source file) in to the master copy that will be distributed to the wider user base.

As to your latest specific ideas in this request. You just need to be patient and wait for the next official release which will implement an option to combine scope and AWG controls into the main window with the XY plot in a separate window. The first pass at a method to localize the language through an optional configuration file will also be included.

Please limit pull requests to fatal bug fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants