bindings/python: Fix the adsd3500 getter functions

In python we can't send an int or bool or double as a reference. Therefore we need to make the getter to return the value we want to read. So send a pair made from status of the call and the read value. Client code will need to read the second item from the pair to get the value. Signed-off-by: Dan Nechita <[email protected]>
analogdevicesinc · Jun 28, 2023 · e551cab · e551cab
1 parent 1ce2e2c
commit e551cab
Showing 1 changed file with 35 additions and 17 deletions.
diff --git a/bindings/python/aditofpython.cpp b/bindings/python/aditofpython.cpp
@@ -294,42 +294,60 @@ PYBIND11_MODULE(aditofpython, m) {
              &aditof::Camera::adsd3500SetABinvalidationThreshold,
              py::arg("threshold"))
         .def("adsd3500GetABinvalidationThreshold",
-             &aditof::Camera::adsd3500GetABinvalidationThreshold,
-             py::arg("threshold"))
-        .def("adsd3500SetConfidenceThreshold",
-             &aditof::Camera::adsd3500SetConfidenceThreshold,
-             py::arg("threshold"))
-        .def("adsd3500GetConfidenceThreshold",
-             &aditof::Camera::adsd3500GetConfidenceThreshold,
-             py::arg("threshold"))
+             [](aditof::Camera &camera) {
+                 int threshold;
+                 aditof::Status status =
+                     camera.adsd3500GetABinvalidationThreshold(threshold);
+                 return std::make_pair(status, threshold);
+             })
         .def("adsd3500SetConfidenceThreshold",
              &aditof::Camera::adsd3500SetConfidenceThreshold,
              py::arg("threshold"))
         .def("adsd3500GetConfidenceThreshold",
-             &aditof::Camera::adsd3500GetConfidenceThreshold,
-             py::arg("threshold"))
+             [](aditof::Camera &camera) {
+                 int threshold;
+                 aditof::Status status =
+                     camera.adsd3500GetConfidenceThreshold(threshold);
+                 return std::make_pair(status, threshold);
+             })
         .def("adsd3500SetJBLFfilterEnableState",
              &aditof::Camera::adsd3500SetJBLFfilterEnableState,
              py::arg("enable"))
         .def("adsd3500GetJBLFfilterEnableState",
-             &aditof::Camera::adsd3500GetJBLFfilterEnableState,
-             py::arg("enabled"))
+             [](aditof::Camera &camera) {
+                 bool enableState;
+                 aditof::Status status =
+                     camera.adsd3500GetJBLFfilterEnableState(enableState);
+                 return std::make_pair(status, enableState);
+             })
         .def("adsd3500SetJBLFfilterSize",
              &aditof::Camera::adsd3500SetJBLFfilterSize, py::arg("size"))
         .def("adsd3500GetJBLFfilterSize",
-             &aditof::Camera::adsd3500GetJBLFfilterSize, py::arg("size"))
+             [](aditof::Camera &camera) {
+                 int size;
+                 aditof::Status status = camera.adsd3500GetJBLFfilterSize(size);
+                 return std::make_pair(status, size);
+             })
         .def("adsd3500SetRadialThresholdMin",
              &aditof::Camera::adsd3500SetRadialThresholdMin,
              py::arg("threshold"))
         .def("adsd3500GetRadialThresholdMin",
-             &aditof::Camera::adsd3500GetRadialThresholdMin,
-             py::arg("threshold"))
+             [](aditof::Camera &camera) {
+                 int threshold;
+                 aditof::Status status =
+                     camera.adsd3500GetRadialThresholdMin(threshold);
+                 return std::make_pair(status, threshold);
+             })
         .def("adsd3500SetRadialThresholdMax",
              &aditof::Camera::adsd3500SetRadialThresholdMax,
              py::arg("threshold"))
         .def("adsd3500GetRadialThresholdMax",
-             &aditof::Camera::adsd3500GetRadialThresholdMax,
-             py::arg("threshold"))
+             [](aditof::Camera &camera) {
+                 int threshold;
+                 aditof::Status status =
+                     camera.adsd3500GetRadialThresholdMax(threshold);
+                 return std::make_pair(status, threshold);
+             })
         .def("adsd3500SetMIPIOutputSpeed",
              &aditof::Camera::adsd3500SetMIPIOutputSpeed, py::arg("speed"))
         .def("adsd3500GetMIPIOutputSpeed",