AD7124: update code to match newer linux drivers #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In newer versions of the AD7124 driver, the sampling_frequency is no longer a device-level attribute, but a per-channel attribute. This means that the AD7124 base driver should set this attribute for all enabled channels. Signed-off-by: Alexandru Ardelean <[email protected]>
In a newer version of the AD7124 driver, the channels were all made differential. That means that the channel names need to be updated. This change updates the channel names to the new (differential channel names). Signed-off-by: Alexandru Ardelean <[email protected]>
commodo
requested review from
ribdp,
SaikiranGudla and
jansunil
as code owners
jansunil
requested changes
Nov 29, 2024
SaikiranGudla
approved these changes
Jan 24, 2025
StancaPop
approved these changes
Jan 28, 2025
SaikiranGudla
requested changes
Jan 30, 2025
| @@ -66,7 +66,11 @@ function delete(obj) | |||
| % Set device sampling rate | |||
| obj.SampleRate = value; | |||
| if obj.ConnectedToDevice | |||
| obj.setDeviceAttributeRAW('sampling_frequency', value); | |||
| for i=1:length(obj.channel_names) | |||
There was a problem hiding this comment.
@commodo, Can we update the driver to make sure the no-OS implementation doesn't break with these changes?
In the tinyIIOd-based Firmware implementation, this attribute is treated as a device-level attribute and I see that these changes align with the new Linux drivers.
We can have a new property for channel-sampling-rate attribute naming it as SampleRateCh (or something of that sort or a boolean property that tells if it's a device level or channel level) and this logic can go there (toward its setter function). This way we can have this driver compatible for both the implementations and the attributes can be set accordingly in the example script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist