fix: added missing types to TokenFormatterArgs #1024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenbroekema
approved these changes
Dec 14, 2023
|
FYI this is also fixed in the v4 branch, you could already use the v4 prereleases if you like. I think for now we keep v3 as is, only fixing important bugs or security vulnerabilities. This type issue falls in the category of minor bug, so since it's usually quite easily possible to work around it I'd like to close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
no issue found
Description of changes:
createPropertyFormatter supports more options currently than provided via typescript types. I added these variables to the type.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.