Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade KSP #54

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,5 @@ dependencies {

// Bump transitive dependency.
testImplementation libs.ksp
testImplementation libs.ksp.embeddable
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,14 @@ class Compilation internal constructor(
fun configureKotlinInjectAnvilProcessor(
processorOptions: Map<String, String> = emptyMap(),
symbolProcessorProviders: Set<SymbolProcessorProvider> = emptySet(),
useKsp2: Boolean = true,
): Compilation = apply {
checkNotCompiled()
check(!processorsConfigured) { "Processor should not be configured twice." }

processorsConfigured = true

with(kotlinCompilation) {
if (!useKsp2) {
languageVersion = "1.9"
}

configureKsp(useKsp2 = useKsp2) {
configureKsp(useKsp2 = true) {
this.symbolProcessorProviders += ServiceLoader.load(
SymbolProcessorProvider::class.java,
SymbolProcessorProvider::class.java.classLoader,
Expand Down Expand Up @@ -143,7 +138,6 @@ fun compile(
workingDir: File? = null,
previousCompilationResult: JvmCompilationResult? = null,
moduleName: String? = null,
useKsp2: Boolean = true,
exitCode: KotlinCompilation.ExitCode = KotlinCompilation.ExitCode.OK,
block: JvmCompilationResult.() -> Unit = { },
): JvmCompilationResult {
Expand All @@ -164,7 +158,7 @@ fun compile(
addPreviousCompilationResult(previousCompilationResult)
}
}
.configureKotlinInjectAnvilProcessor(useKsp2 = useKsp2)
.configureKotlinInjectAnvilProcessor()
.compile(*sources)
.also {
if (exitCode == KotlinCompilation.ExitCode.OK) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ class ContributesSubcomponentProcessorTest {
}
""",
scopesSource,
useKsp2 = false,
) {
val component = componentInterface.newComponent<Any>()
val childComponent = component::class.java.methods
Expand Down Expand Up @@ -134,7 +133,7 @@ class ContributesSubcomponentProcessorTest {
addPreviousCompilationResult(previousResult2)
addPreviousCompilationResult(previousResult3)
}
.configureKotlinInjectAnvilProcessor(useKsp2 = false)
.configureKotlinInjectAnvilProcessor()
.compile(
"""
package software.amazon.test
Expand Down Expand Up @@ -209,7 +208,6 @@ class ContributesSubcomponentProcessorTest {
}
""",
scopesSource,
useKsp2 = false,
) {
val components = listOf<Any>(
componentInterface.newComponent(),
Expand Down Expand Up @@ -311,7 +309,6 @@ class ContributesSubcomponentProcessorTest {
}
""",
scopesSource,
useKsp2 = false,
) {
val component = componentInterface.newComponent<Any>()
val childComponent = component::class.java.methods
Expand Down Expand Up @@ -369,7 +366,6 @@ class ContributesSubcomponentProcessorTest {
}
""",
scopesSource,
useKsp2 = false,
) {
val component = componentInterface.newComponent<Any>()
val childComponent = component::class.java.methods
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ class MergeComponentProcessorTest {
abstract val base: Base
}
""",
useKsp2 = false,
) {
assertThat(componentInterface.mergedComponent).isNotNull()

Expand Down Expand Up @@ -206,7 +205,6 @@ class MergeComponentProcessorTest {
}
""",
previousCompilationResult = previousCompilation,
useKsp2 = false,
) {
assertThat(componentInterface.mergedComponent).isNotNull()

Expand Down Expand Up @@ -253,7 +251,6 @@ class MergeComponentProcessorTest {
abstract val base: Base
}
""",
useKsp2 = false,
) {
assertThat(componentInterface.mergedComponent).isNotNull()

Expand Down Expand Up @@ -300,7 +297,6 @@ class MergeComponentProcessorTest {
abstract val base: Base
}
""",
useKsp2 = false,
) {
assertThat(componentInterface.mergedComponent).isNotNull()

Expand Down Expand Up @@ -347,7 +343,6 @@ class MergeComponentProcessorTest {
abstract val base: Base
}
""",
useKsp2 = false,
) {
assertThat(componentInterface.mergedComponent).isNotNull()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ class CustomSymbolProcessorTest {
.configureKotlinInjectAnvilProcessor(
processorOptions = options,
symbolProcessorProviders = setOf(symbolProcessorProvider),
useKsp2 = false,
)
.compile(
"""
Expand Down Expand Up @@ -129,7 +128,6 @@ class CustomSymbolProcessorTest {
.configureKotlinInjectAnvilProcessor(
processorOptions = options,
symbolProcessorProviders = setOf(symbolProcessorProvider),
useKsp2 = false,
)
.addPreviousCompilationResult(previousCompilation)
.compile(
Expand Down Expand Up @@ -172,7 +170,6 @@ class CustomSymbolProcessorTest {
Compilation()
.configureKotlinInjectAnvilProcessor(
symbolProcessorProviders = setOf(symbolProcessorProvider),
useKsp2 = false,
)
.compile(
"""
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ org.gradle.caching=true

kotlin.code.style=official
kotlin.mpp.stability.nowarn=true
ksp.useKSP2=false
ksp.useKSP2=true

# This property does not work when setting up publishing through the DSL as we do.
# SONATYPE_AUTOMATIC_RELEASE=true
Expand Down
3 changes: 2 additions & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ kotlin-hierarchy = "1.1"
kotlin-inject = "0.7.2"
kotlin-poet = "1.18.1"
kotlinx-binaryCompatibilityValidator = "0.16.3"
ksp = "2.0.21-1.0.25"
ksp = "2.0.21-1.0.26"
ktlint-binary = "1.2.1"
ktlint-gradle = "12.1.1"
maven-publish = "0.29.0"
Expand Down Expand Up @@ -43,6 +43,7 @@ kotlin-poet-ksp = { module = "com.squareup:kotlinpoet-ksp", version.ref = "kotli
ksp-gradle-plugin = { module = "com.google.devtools.ksp:com.google.devtools.ksp.gradle.plugin", version.ref = "ksp" }
ksp = { module = "com.google.devtools.ksp:symbol-processing", version.ref = "ksp" }
ksp-api = { module = "com.google.devtools.ksp:symbol-processing-api", version.ref = "ksp" }
ksp-embeddable = { module = "com.google.devtools.ksp:symbol-processing-aa-embeddable", version.ref = "ksp" }
ktlint-gradle-plugin = { module = "org.jlleitschuh.gradle:ktlint-gradle", version.ref = "ktlint-gradle" }
maven-publish-gradle-plugin = { module = "com.vanniktech:gradle-maven-publish-plugin", version.ref = "maven-publish" }

Expand Down
Loading