Skip to content

Make arctan2 work with Quantities #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rieder merged 2 commits into from
Oct 2, 2025
Merged

Make arctan2 work with Quantities #1179

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a805cc0
Make arctan2 work with ScalarQuantities
rieder Oct 1, 2025
8880b04
Update for case with regular Float inputs, add tests
rieder Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/amuse/units/trigo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@
arcsin = lambda x: numpy.arcsin(x) | rad
arccos = lambda x: numpy.arccos(x) | rad
arctan = lambda x: numpy.arctan(x) | rad
arctan2 = lambda x, y: numpy.arctan2(x, y) | rad
arctan2 = lambda x, y: numpy.arctan2(
x.value_in(x.unit),
y.value_in(x.unit),
) | rad


def to_rad(angle):
Expand Down
Loading