Fix SimpleX #1146
Merged
Fix SimpleX #1146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Works with Conda, but not yet with venv (qhull is not detected as being installed). |
Member
|
Still, recommended we merge this and treat that as a new, separate issue. |
rieder
approved these changes
Jun 2, 2025
Member
Author
|
I upgraded it to libqhull_r, so that fixed the Conda problem. I made #1151 for the remaining macOS venv qhull detection issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleX didn't build mostly because it vendored some ancient versions of QHull and HEALPix. This adds those dependencies to our configury so that we can get them from the system, removes them from SimpleX, converts SimpleX to the new build system and fixes it so that it works.
This currently works only in a virtualenv and not in conda, because of conda-forge/qhull-feedstock#23. That needs to get fixed first, so that we can test this with conda too and then merge it.
@rieder could you give this a try on macOS in a venv? I have only tested it on Linux. Thanks!
Closes #1111.