chore: replace hardcoded values with spacer vars #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jecr
requested review from
Golodhros,
ttannis,
allisonsuarez,
feng-tao,
verdan,
mgorsk1,
sewardgw,
youngyjd,
dechoma,
kristenarmes,
ozandogrultan and
B-T-D
as code owners
|
Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md) |
Signed-off-by: Jorge Cortés <[email protected]>
kristenarmes
approved these changes
Dec 5, 2024
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TableDetailPage/styles.scss: Replaced usage of hardcoded values with spacer vars where appropriate
Motivation and Context
Follow to for this comment, as the PR where this was suggested has been closed already
How Has This Been Tested?
Manually
CheckList