rustls: do not depend on unnecessary features #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
rustls-fix
branch
2 times, most recently
from
d4f2a5a to
eb2a5ed
Compare
|
Hello, I'd prefer going with option a and enabling the same as rustls by default here. |
phip1611
added a commit
to phip1611/ttfb
that referenced
this pull request
May 1, 2024
phip1611
added a commit
to phip1611/ttfb
that referenced
this pull request
May 1, 2024
|
Works. For reference: phip1611/ttfb#55 |
The main motivation for that change is to prevent an unnecessary dependency to rustls/aws_lc_rs [0]. aws_lc_rs has a non-default build with external tools (cmake, nasm) which breaks CI in consumer projects, such as ttfb [1]. So instead of forcing it, we make it optional. [0]: https://docs.rs/rustls/latest/rustls/#crate-features [1]: https://github.com/phip1611/ttfb/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation for that change is to prevent an unnecessary dependency to rustls/aws_lc_rs [0]. aws_lc_rs has a non-default build with external tools (cmake, nasm) which breaks CI in consumer projects, such as ttfb [1].
I'm not sure what's the best solution here:
rustlsas dependency and specify the corresponding depI think b) is fine.
[0] : https://docs.rs/rustls/latest/rustls/#crate-features
[1] : https://github.com/phip1611/ttfb/