feat: Cookie consent exposure handling #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📝 Documentation updates detected! Updated existing suggestion: Document cookie consent handling for Experiment JavaScript SDK |
tyiuhc
requested review from
a team,
bgiori and
zhukaihan
and removed request for
bgiori
packages/experiment-tag/src/exposure/consent-aware-exposure-handler.ts
Outdated
Show resolved
Hide resolved
stephen-choi-amplitude
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This update will support consent-aware firing of
$impressionevents.Behavior in different states:
GRANTED: will fire events as normal - immediately when variant actions are appliedREJECTED: script will not be runPENDING: events will be stored in memory, and only fired when consent status is changed toGRANTED$impressionevents are update to contain a timestamp to indicate when the event occurred, which will override the timestamp generated by theanalytics-browserupon processing. (Relevant PR1, PR2). This is necessary for timestamp accuracy for delayed$impressionfiring during thePENDINGstate.Checklist