fix(plugin-autocapture-browser): do not trigger rage click when text being highlighted #1471
+228
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected]
This reverts commit b6afc2a.
This reverts commit db34376.
…cript into AMP-146045-rage-click-fix-mobile-scroll-false-positive
- @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected] - @amplitude/[email protected]
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
daniel-graham-amplitude
changed the title
Comment on lines
+201
to
+205
| unsubscribe: () => { | ||
| rageClickSubscription.unsubscribe(); | ||
| /* istanbul ignore next */ | ||
| selectionSubscription?.unsubscribe(); | ||
| }, |
Contributor
There was a problem hiding this comment.
Pending rage‑click timeout isn’t cleared, so it can fire after teardown or a window reset and emit unexpectedly. Suggest always cancel and null any pending rageClick timer during teardown and whenever the click window is reset.
Suggested change
| unsubscribe: () => { | |
| rageClickSubscription.unsubscribe(); | |
| /* istanbul ignore next */ | |
| selectionSubscription?.unsubscribe(); | |
| }, | |
| unsubscribe: () => { | |
| if (pendingRageClick) { | |
| // eslint-disable-next-line @typescript-eslint/no-unsafe-argument | |
| clearTimeout(pendingRageClick.timerId); | |
| pendingRageClick = null; | |
| } | |
| rageClickSubscription.unsubscribe(); | |
| /* istanbul ignore next */ | |
| selectionSubscription?.unsubscribe(); | |
| }, |
🚀 Want me to fix this? Reply ex: "fix it for me".
Collaborator
Author
There was a problem hiding this comment.
This is fine, this was here before. It just means that if it's unsubscribed and a rage click happens within the short window after unsubscribing, it will fire off one last event.
daniel-graham-amplitude
force-pushed
the
AMP-146045-rage-click-fix-mobile-scroll-false-positive
branch
from
3696ef2 to
2f9f9a5
Compare
… of github.com:amplitude/Amplitude-TypeScript into AMP-146044-fix-highlightable-text-rage-clicks
… AMP-146045-rage-click-fix-mobile-scroll-false-positive
… of github.com:amplitude/Amplitude-TypeScript into AMP-146044-fix-highlightable-text-rage-clicks
Base automatically changed from
AMP-146045-rage-click-fix-mobile-scroll-false-positive
to
main
January 5, 2026 22:37
… AMP-146044-fix-highlightable-text-rage-clicks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
📝 Documentation updates detected! New suggestion: Document rage click text selection behavior |
Mercy811
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cancel a rage click if there is a text highlight event that happens after a click.
If a user clicks 1 or more times, and then text is highlighted, that suggests that the user's clicks caused the text to be highlighted
Here's a demonstration to show if you highlight text in an input, the first 3 clicks cause the text to be highlighted, which cancels out the rage click. You thus need at least 7 clicks for it to be a rage click (4 clicks after the text is done being highlighted).
Screen.Recording.2026-01-02.at.5.41.11.PM.mov
Checklist
Note
Prevents rage-click events when user text selection occurs by integrating a new observable and resetting detection state.
SelectionObservabletoAllWindowObservablesand wires it infrustration-pluginviadocument.selectionchange(handles inputs/textareas and generic selections)track-rage-clickto subscribe toselectionObservableandresetClickWindow()on selection; returns a composite subscription that unsubscribes both click and selection listenersObservablesEnum) to includeselectionObservablefrustration-plugin.test.tsandtrack-rage-click.test.tsWritten by Cursor Bugbot for commit 9eb5742. This will update automatically on new commits. Configure here.