Skip to content

fix(analytics-browser): diagnostics track user agent (#1428) #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mercy811 wants to merge 4 commits into
base: feat-zoning-1211
Choose a base branch
from
Open

fix(analytics-browser): diagnostics track user agent (#1428) #1436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e01f0dd
fix(analytics-browser): diagnostics track user agent (#1428)
Mercy811 Dec 11, 2025
65617cb
Revert "fix(analytics-browser): diagnostics track user agent (#1428)"
Mercy811 Dec 29, 2025
8d8d263
Reapply "fix(analytics-browser): diagnostics track user agent (#1428)"
Mercy811 Dec 29, 2025
d9c897d
test: increase timeout
Mercy811 Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/analytics-browser-test/test/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2075,7 +2075,7 @@ describe('integration', () => {
resolve();
}, 4000);
});
});
}, 10000);

test('should send page view', () => {
let payload: any = undefined;
Expand Down
1 change: 1 addition & 0 deletions packages/analytics-browser/src/browser-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ export class AmplitudeBrowser extends AmplitudeCore implements BrowserClient, An
},
);
diagnosticsClient.setTag('library', `${LIBPREFIX}/${VERSION}`);
diagnosticsClient.setTag('user_agent', navigator.userAgent);
Copy link
Contributor

@macroscopeapp macroscopeapp bot Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessing navigator.userAgent without a guard can crash in non‑browser contexts. Consider guarding with typeof navigator !== 'undefined' (like in Context) before setting the tag.

Suggested change
diagnosticsClient.setTag('user_agent', navigator.userAgent);
if (typeof navigator !== 'undefined') {
diagnosticsClient.setTag('user_agent', navigator.userAgent);
}

🚀 Want me to fix this? Reply ex: "fix it for me".


await super._init(browserOptions);
this.logBrowserOptions(browserOptions);
Expand Down
Loading