-
Notifications
You must be signed in to change notification settings - Fork 56
fix: diagnostics track uncaught sdk errors #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7e0a562 to
caf64f8
Compare
|
bugbot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment @cursor review or bugbot run to trigger another review on this PR
packages/analytics-core/src/diagnostics/diagnostics-uncaught-sdk-error-global-tracker.ts
Outdated
Show resolved
Hide resolved
|
bugbot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
Comment @cursor review or bugbot run to trigger another review on this PR
|
bugbot run |
|
bugbot run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
Comment @cursor review or bugbot run to trigger another review on this PR
|
Overall lgtm. |
|
Closing this and go with #1419 instead |
Summary
https://amplitude.atlassian.net/wiki/spaces/GOV/pages/3501359165/Diagnostics+track+uncaught+SDK+errors#1.-Execution-Context-Tracking
DO NOT MERGE NOW
Let diagnostics track uncaught errors from the SDK.
#1413
Implementation:
Test server example:
GMT20251125-010300_Clip_Diagnostics.capture.uncaught.sdk.error.mp4
Checklist
Note
Adds execution-context tracking and global web handlers to report uncaught SDK errors to Diagnostics, applies tracking to init/process, exposes decorator, and adds tests/demo; enables decorators in TS config.
diagnostics-uncaught-sdk-error-global-trackerwithgetExecutionTracker,DiagnosticsUncaughtErrordecorator, and error tagging helpers.diagnostics-uncaught-sdk-error-web-handlersto captureerrorandunhandledrejectionand recordanalytics.errors.uncaughtviaIDiagnosticsClient.DiagnosticsClientwhen sampled/enabled.DiagnosticsUncaughtErrorfromsrc/index.ts.AmplitudeBrowser._initandprocesswith@DiagnosticsUncaughtErrorto mark SDK execution.index.test.tsto validate new export.test-server/diagnostics.htmlto demonstrate dropped events and uncaught error capture scenarios.experimentalDecoratorsintsconfig.json.Written by Cursor Bugbot for commit 5810cc2. Configure here.