feat(autocapture): set page url enrichment plugin to default on and add/fix tests #1287
Conversation
|
📝 Documentation updates detected! New suggestion: Document page URL enrichment plugin enabled by default in Browser SDK |
cyhk
force-pushed
the
AMP-139733
branch
2 times, most recently
from
1575dc2 to
bff7861
Compare
| generateSessionEndEvent(++eventId), | ||
| addPageUrlEnrichmentProperties(generateSessionStartEvent(++eventId), url), | ||
| generatePageViewEvent(++eventId, 1, url, undefined, { previousPageUrl: '' }), | ||
| addPageUrlEnrichmentProperties(generateSessionEndEvent(++eventId), directUrl, url), |
There was a problem hiding this comment.
Tests are passing and make sense to me, except this (and other similar cases with session_end events have what is expected to be the next page's data.
When do session end events get fired?
There was a problem hiding this comment.
I just noticed this now. session_end events get tracked when a user visits a website that has Amplitude tracking on it and the "lastEventTime" (which gets updated to the latest time every event) is >30 minutes in the past. When that happens, the client creates a "session_end" event and fires it with "lastEventTime + 1" as it's timestamp.
So the session end events are uploaded at least 30 minutes after the last event in the session takes place. But usually it's way after that.
cyhk
force-pushed
the
AMP-139733
branch
3 times, most recently
from
fcc7160 to
7674bda
Compare
3 participants
Summary
Fix tests and release page-url-enrichment-plugin to default on for customers
Checklist