fix: add swift version in podspec #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chungdaniel
requested changes
Jan 2, 2025
There was a problem hiding this comment.
Thanks @martin-headspace for adding this! We should also change the commit to be fix: rather than chore: so that it'll trigger a build/release.
Some extra context: We're working on releasing a 4.x of our Flutter SDK which will point to our iOS Swift SDK, which will use a swift_version of '5.9'. I've made a note to add this change to our beta branch for including a swift_version for 4.x
martin-headspace
force-pushed
the
chore/add-swift-version-in-pubspec
branch
from
3be9afd to
ac6919f
Compare
martin-headspace
changed the title
chungdaniel
requested changes
Jan 2, 2025
Adds the Swift Version to the Podspec to help developers with an add-to-app setup not run into the missing SWIFT_VERSION error when compiling.
martin-headspace
force-pushed
the
chore/add-swift-version-in-pubspec
branch
from
ac6919f to
916f027
Compare
chungdaniel
approved these changes
Jan 2, 2025
justin-fiedler
pushed a commit
that referenced
this pull request
Jan 2, 2025
## [3.16.6](v3.16.5...v3.16.6) (2025-01-02) ### Bug Fixes * add swift version in podspec ([#210](#210)) ([e702ee5](e702ee5))
|
🎉 This PR is included in version 3.16.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Added the
swift_versionto the Podspec to help developers with anadd-to-appsetup not run into the missingSWIFT_VERSIONerror when compiling.Rationale
When using this plugin on a project that is being compiled for the add-to-app approach in Flutter, developers will usually get this error:
To fix this, developers have to go into their generated Podspec and add the
SWIFT_VERSIONenvironment variable for the build to work. This is not an ideal workflow.By adding the Swift Version to the Podspec, builds compile without a hitch.