Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devise/override: add active_for_authentication? #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mulander
Copy link

in commit
heartcombo/devise@edee511

devise renamed active? to active_for_authentication?
we override that method to prevent suspended accounts
from logging in which doesn't work after devise v1.2.0

Signed-off-by: Adam Wolk [email protected]

in commit
heartcombo/devise@edee511

devise renamed active? to active_for_authentication?
we override that method to prevent suspended accounts
from logging in which doesn't work after devise v1.2.0

Signed-off-by: Adam Wolk <[email protected]>
@mulander
Copy link
Author

Hi, thanks for updating the gem and publishing it to rubygems!

I cross checked the published version and it appears that it contains changes that are not present in this repository, perhaps you forgot to push v6.0.1 to github?

Regarding the change in the pull request itself, I defaulted to keeping the old active? method and adding the new one, however if you are OK with it, I think the old active? one should be removed (essentially just renamed) - the version of devise that renamed the method came out 7 years ago, don't think many people still use the old one with no ability to upgrade - what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant