Skip to content

fix(vue): support reactive lyric lines - #592

Draft
sin6626 wants to merge 1 commit into
amll-dev:mainfrom
sin6626:codex/fix-vue-reactive-lyric-lines
Draft

fix(vue): support reactive lyric lines#592
sin6626 wants to merge 1 commit into
amll-dev:mainfrom
sin6626:codex/fix-vue-reactive-lyric-lines

Conversation

@sin6626

@sin6626 sin6626 commented Aug 18, 2026

Copy link
Copy Markdown

Summary

  • unwrap Vue reactive proxies before passing lyricLines to Core
  • add a regression test covering deeply reactive ref<LyricLine[]>() data
  • use a regular ref in the Vue playground and document the supported usage in English and Chinese

Problem

The Vue binding currently forwards a deeply reactive lyrics array directly to Core. Core clones lyric lines with structuredClone, which throws a DataCloneError when the value is a Vue Proxy. As a result, using the natural Vue API (ref([])) can leave the lyric player empty.

Verification

  • pnpm --filter @applemusic-like-lyrics/vue test
  • pnpm --filter @applemusic-like-lyrics/vue typecheck
  • pnpm test:libs
  • pnpm release:plan:check
  • Vue package build
  • Biome lint on changed Vue source and test files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant