Skip to content

Compatibility fix for node 5.5.0 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
david-benes wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Compatibility fix for node 5.5.0 #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
var http = require('http')
, Service = require('./service')
, url = require('url')

module.exports = function getAgent (options) {

Expand All @@ -12,6 +13,10 @@ module.exports = function getAgent (options) {
// All we're doing is asynchronously retrieving a spec (host + port) given the
// virtual host, and passing that to a real HTTP agent.
Agent.prototype.addRequest = function (req, service) {
// Fix for node 5.5.0+ where service contains options instead of hostname
if (service.href) {
service = url.parse(service.href).hostname;
}
var self = this;
if (!req.listeners('spec').length) {
req.on('spec', function (spec) {
Expand Down