feat(account): implement mergeAccount()#92
Open
Andreschuks101 wants to merge 1 commit intoamina69:developfrom
Open
feat(account): implement mergeAccount()#92Andreschuks101 wants to merge 1 commit intoamina69:developfrom
Andreschuks101 wants to merge 1 commit intoamina69:developfrom
Conversation
…andling - Accept escrowAccountId and destinationAccountId params - Validate both public keys and master secret key - Build AccountMerge operation from escrow account - Sign with masterSecretKey (platform holds medium threshold weight) - Submit and return mergedAccountId and txHash - Throw TrustlineError when escrow has non-native trustlines - Add unit tests for validation, trustline error, and merge result Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@Andreschuks101 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
@Andreschuks101 fix conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mergeAccount()to merge settled escrow accounts back into destination accountsescrowAccountIdanddestinationAccountIdpublic keysAccountMergeoperation, signs withmasterSecretKey, and submits{ mergedAccountId, txHash }on successTrustlineErrorwhen escrow has non-native trustlines (cannot merge)Test plan
npm test— all 84 tests passCloses #58