Account management create#67
Open
innovativedesign-lab wants to merge 6 commits intoamina69:developfrom
Open
Conversation
|
@innovativedesign-lab Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
Done, Close: #67 |
Owner
|
@innovativedesign-lab read the contributing.md |
Author
Done - Pushed to Develop, Close: #67 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #55
The main implementation is in [src/accounts/index.ts, where createAccount():
accepts { publicKey, startingBalance? } with default '2.5'
validates publicKey with isValidPublicKey()
throws ValidationError for invalid keys
loads the master account from Horizon
throws AccountNotFoundError if the master account is missing
builds a Stellar Operation.createAccount(...) transaction
signs it with masterSecretKey
submits through the injected HorizonClient
returns { accountId, transactionHash, startingBalance }
There are also unit tests in [tests/unit/accounts/createAccount.test.ts]
covering:
success
invalid key
missing master account
insufficient master balance