Open
Conversation
Author
|
Done, Close: #64 |
Owner
|
@OluRemiFour you are suppose to push to develop not main. and was also suppose to branch of develop, it in the contributing.md...please read it before starting the project |
|
@OluRemiFour Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
Fixed |
amina69
approved these changes
Mar 27, 2026
Owner
|
@OluRemiFour checks failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #52
Updated isValidDistribution() in [src/utils/validation.ts to enforce all the requested rules:
non-empty array
every recipient must pass isValidPublicKey()
every percentage must satisfy 0 < p <= 100
total must equal exactly 100 using scaled integer math instead of float rounding
I also expanded coverage in [tests/unit/utils/validation.test.ts] for decimal splits, invalid recipients, zero/over-100 values, and non-exact totals.
Verification passed with npm run type-check and npm test -- --runInBand.