Skip to content

Account management validator#64

Open
OluRemiFour wants to merge 6 commits intoamina69:developfrom
OluRemiFour:account-management-validator
Open

Account management validator#64
OluRemiFour wants to merge 6 commits intoamina69:developfrom
OluRemiFour:account-management-validator

Conversation

@OluRemiFour
Copy link
Copy Markdown

Close: #52
Updated isValidDistribution() in [src/utils/validation.ts to enforce all the requested rules:

non-empty array
every recipient must pass isValidPublicKey()
every percentage must satisfy 0 < p <= 100
total must equal exactly 100 using scaled integer math instead of float rounding
I also expanded coverage in [tests/unit/utils/validation.test.ts] for decimal splits, invalid recipients, zero/over-100 values, and non-exact totals.

Verification passed with npm run type-check and npm test -- --runInBand.

@OluRemiFour
Copy link
Copy Markdown
Author

Done, Close: #64

@amina69
Copy link
Copy Markdown
Owner

amina69 commented Mar 26, 2026

@OluRemiFour you are suppose to push to develop not main. and was also suppose to branch of develop, it in the contributing.md...please read it before starting the project

@OluRemiFour OluRemiFour changed the base branch from main to develop March 26, 2026 12:07
@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 26, 2026

@OluRemiFour Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@OluRemiFour
Copy link
Copy Markdown
Author

@OluRemiFour you are suppose to push to develop not main. and was also suppose to branch of develop, it in the contributing.md...please read it before starting the project

Fixed

@amina69
Copy link
Copy Markdown
Owner

amina69 commented Mar 27, 2026

@OluRemiFour checks failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SDK · Account management] Implement isValidDistribution() validator

3 participants