feat: implement decodeMemo() transaction helper — closes #111#141
Open
spiffamani wants to merge 1 commit intoamina69:mainfrom
Open
feat: implement decodeMemo() transaction helper — closes #111#141spiffamani wants to merge 1 commit intoamina69:mainfrom
spiffamani wants to merge 1 commit intoamina69:mainfrom
Conversation
- Add src/transactions/builder.ts with decodeMemo() - MEMO_NONE returns null - MEMO_TEXT returns original string - MEMO_ID returns numeric value as string - MEMO_HASH returns hex digest string - MEMO_RETURN returns hex digest string - Export decodeMemo and DecodedMemo from transactions and public index - Add 7 unit tests covering all memo types
Owner
|
@spiffamani you are making pr to the wrong branch, read the conributing.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
decodeMemo()helper for decoding Stellar memo objects, closing #111.Changes
src/transactions/builder.ts— AddeddecodeMemo()andDecodedMemotypesrc/transactions/index.ts— Re-exportsdecodeMemoandDecodedMemosrc/index.ts— ExportsdecodeMemoandDecodedMemofrom public surfacetests/unit/transactions/decodeMemo.test.ts— 7 unit testsMemo Type Handling
nullUsage
Test Results
Checklist
src/transactions/builder.tsnpm testpasses