Implement custody return and violation lifecycle#97
Open
kingjosmel wants to merge 2 commits intoamina69:mainfrom
Open
Implement custody return and violation lifecycle#97kingjosmel wants to merge 2 commits intoamina69:mainfrom
kingjosmel wants to merge 2 commits intoamina69:mainfrom
Conversation
|
@kingjosmel Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
@kingjosmel test failed |
Author
|
@amina69 i've fix the test |
Owner
|
@kingjosmel kindly fixed this small conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Implement Custody Return and Violation Lifecycle
close #63
Overview
This PR implements the complete custody return lifecycle, including escrow resolution and trust score updates. It adds methods to handle successful custody returns and violations with proper event logging.
Features
Return Custody:
returnCustody(custodyId)- End custody successfullyViolation Custody:
violationCustody(custodyId)- Report custody violationTrust Score Management:
updateTrustScore(userId, delta)- Update user trust scoresEscrow Refund:
refundEscrow(escrowId)- Refund escrow on violationsAPI Endpoints:
POST /custody/:id/return- Return custody agreementPOST /custody/:id/violation- Mark custody as violationAcceptance Criteria
✅ Successful custody releases escrow
✅ Violation refunds escrow
✅ Trust score updated correctly
✅ EventLog entries created
✅ Pet availability updated (computed dynamically)
Notes