-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RT Capabilities Part 1 - robot-log-visualizer #80
base: main
Are you sure you want to change the base?
Conversation
@@ -239,15 +239,25 @@ def setupUi(self, MainWindow): | |||
icon = QtGui.QIcon.fromTheme("exit") | |||
self.actionQuit.setIcon(icon) | |||
self.actionQuit.setObjectName("actionQuit") | |||
|
|||
# Add the GUI components for the open action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an autogenerated file and cannot be touched the correct approach here is to modify the UI file directly with qtcreator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in be77f98
robot_log_visualizer/ui/gui.py
Outdated
# Disable these buttons for RT communication | ||
self.ui.startButton.setEnabled(False) | ||
self.ui.timeSlider.setEnabled(False) | ||
self.network_thread = threading.Thread(target=self.establish_connection, args=(root,)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use qtthread here?
I'm cleaning a bit the PR to move the blf deps optional so the feature can be ported to pip |
Hi @nicktrem let me know when it's ready so I can start checking it :) |
@nicktrem @GiulioRomualdi there is any update on this? Thanks! |
It is good to go on my end @GiulioRomualdi let me know if you have any questions |
According to @GiulioRomualdi he did some tests on the real robot, and he did not remember well, but when using the RT logger, something related to saving the data was not working. |
That issue is on the BLF side, not the robot-log-visualizer side. I can investigate that separately, however, that issue is separate from this PR |
This PR for the robot-log-visualizer is a smaller simpler version of the original PR for the robot-log-visualizer and just contains the bare-bone code needed to visualize data online. The point of breaking up the original PR was to simplify the merge process for the robot-log-visualizer.