forked from AdaGold/code-reviews
-
Couldn't load subscription status.
- Fork 0
Add Two Sum #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ameerrah9
wants to merge
1
commit into
master
Choose a base branch
from
ghameerah/two_sum
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Two Sum #1
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,5 @@ | ||
| def twoSum(n, t): | ||
| pass | ||
| for i in range(len(n)): | ||
| for j in range(i + 1, len(n)): | ||
| if n[j] == t - n[i]: | ||
| return [i, j] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice return statement |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,37 @@ | ||
| import pytest | ||
| from functions.two_sum import twoSum | ||
|
|
||
| def test_returns_0_1_for_2_7_11_15_with_target_9(): | ||
| # Arrange | ||
| n = [2, 7, 11, 15] | ||
| t = 9 | ||
|
|
||
| # Act | ||
| answer = twoSum(n, t) | ||
|
|
||
| # Assert | ||
| assert answer == [0, 1] | ||
|
|
||
|
|
||
| def test_returns_1_2_for_3_2_4_with_target_6(): | ||
| # Arrange | ||
| n = [3, 2, 4] | ||
| t = 6 | ||
|
|
||
| # Act | ||
| answer = twoSum(n, t) | ||
|
|
||
| # Assert | ||
| assert answer == [1, 2] | ||
|
|
||
|
|
||
| def test_returns_0_1_for_3_3_with_target_6(): | ||
| # Arrange | ||
| n = [3, 3] | ||
| t = 6 | ||
|
|
||
| # Act | ||
| answer = twoSum(n, t) | ||
|
|
||
| # Assert | ||
| assert answer == [0, 1] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I'm concerned about the time complexity of this function? Do think there is a way to lower it?