Skip to content

fix: correct COPY paths in credential sidecar Dockerfiles for CI build context #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Jun 1, 2026
+8 −8
Merged

fix: correct COPY paths in credential sidecar Dockerfiles for CI build context #1627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8c8939
fix: correct COPY paths in credential sidecar Dockerfiles for CI buil…
Jun 1, 2026
0803cc7
Merge branch 'main' into fix/credential-sidecar-dockerfile-context
mergify[bot] Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/credential-sidecars/github/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

USER 0
WORKDIR /build
COPY components/credential-sidecars/entrypoint/ ./entrypoint/
COPY components/ambient-mcp/ ./ambient-mcp/
COPY credential-sidecars/entrypoint/ ./entrypoint/
COPY ambient-mcp/ ./ambient-mcp/

WORKDIR /build/entrypoint
RUN go mod edit -replace github.com/ambient-code/platform/components/ambient-mcp=../ambient-mcp && \
Expand All @@ -21,7 +21,7 @@
COPY --from=upstream /server/github-mcp-server /opt/app-root/bin/github-mcp-server
COPY --from=builder /credential-entrypoint /opt/app-root/bin/credential-entrypoint

ENV CREDENTIAL_PROVIDER=github

Check warning on line 24 in components/credential-sidecars/github/Dockerfile

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, linux/amd64, amd64, credential-github, ./components, quay.io/ambient_code/v...

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CREDENTIAL_PROVIDER")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 24 in components/credential-sidecars/github/Dockerfile

View workflow job for this annotation

GitHub Actions / build (ubuntu-24.04-arm, linux/arm64, arm64, credential-github, ./components, quay.io/ambient_cod...

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CREDENTIAL_PROVIDER")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

USER 1001

Expand Down
4 changes: 2 additions & 2 deletions components/credential-sidecars/google/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ FROM registry.access.redhat.com/ubi9/go-toolset:1.24 AS builder

USER 0
WORKDIR /build
COPY components/credential-sidecars/entrypoint/ ./entrypoint/
COPY components/ambient-mcp/ ./ambient-mcp/
COPY credential-sidecars/entrypoint/ ./entrypoint/
COPY ambient-mcp/ ./ambient-mcp/

WORKDIR /build/entrypoint
RUN go mod edit -replace github.com/ambient-code/platform/components/ambient-mcp=../ambient-mcp && \
Expand Down
4 changes: 2 additions & 2 deletions components/credential-sidecars/jira/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ FROM registry.access.redhat.com/ubi9/go-toolset:1.24 AS builder

USER 0
WORKDIR /build
COPY components/credential-sidecars/entrypoint/ ./entrypoint/
COPY components/ambient-mcp/ ./ambient-mcp/
COPY credential-sidecars/entrypoint/ ./entrypoint/
COPY ambient-mcp/ ./ambient-mcp/

WORKDIR /build/entrypoint
RUN go mod edit -replace github.com/ambient-code/platform/components/ambient-mcp=../ambient-mcp && \
Expand Down
4 changes: 2 additions & 2 deletions components/credential-sidecars/k8s/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

USER 0
WORKDIR /build
COPY components/credential-sidecars/entrypoint/ ./entrypoint/
COPY components/ambient-mcp/ ./ambient-mcp/
COPY credential-sidecars/entrypoint/ ./entrypoint/
COPY ambient-mcp/ ./ambient-mcp/

WORKDIR /build/entrypoint
RUN go mod edit -replace github.com/ambient-code/platform/components/ambient-mcp=../ambient-mcp && \
Expand All @@ -23,7 +23,7 @@

COPY --from=builder /credential-entrypoint /usr/local/bin/credential-entrypoint

ENV CREDENTIAL_PROVIDER=kubeconfig

Check warning on line 26 in components/credential-sidecars/k8s/Dockerfile

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, linux/amd64, amd64, credential-k8s, ./components, quay.io/ambient_code/vtea...

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CREDENTIAL_PROVIDER")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

Check warning on line 26 in components/credential-sidecars/k8s/Dockerfile

View workflow job for this annotation

GitHub Actions / build (ubuntu-24.04-arm, linux/arm64, arm64, credential-k8s, ./components, quay.io/ambient_code/v...

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "CREDENTIAL_PROVIDER")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

USER 1001

Expand Down
Loading