feat(ambient-ui): walking skeleton with BFF auth, fleet view, and deployment#1612
Merged
Conversation
Contributor
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughAdds a new ambient-ui Next.js app with SDK adapters and hooks, authentication (SSO/oauth-proxy), BFF proxy routes, UI components and pages, React Query setup, CI/build integration, and Kubernetes/OpenShift manifests for local and production deployments. ChangesAmbient UI app and platform integration
Sequence Diagram(s)sequenceDiagram
participant UI
participant NextAPI
participant UpstreamAPI
UI->>NextAPI: /api/ambient/v1/... (GET/POST/PUT/PATCH/DELETE)
NextAPI->>UpstreamAPI: Forward with Authorization
UpstreamAPI-->>NextAPI: JSON/stream
NextAPI-->>UI: Proxied response/stream
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
|
✅ Deploy Preview for cheerful-kitten-f556a0 canceled.
|
- Remove turbopack.root (caused full monorepo filesystem scan → RAM spike) - Add outputFileTracingRoot to silence workspace root warning - Switch dev script to --webpack to handle symlinked ambient-sdk correctly - Rename middleware.ts → proxy.ts and export as `proxy` (Next.js 16 convention) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…loyment Next.js BFF ops console implementing the ambient-ui spec's walking skeleton: - Dual-mode OIDC auth (native-sso/oauth-proxy/none) with iron-session - Port/adapter API layer decoupling domain types from generated SDK - Project selector, sidebar navigation, Fleet table with adaptive polling - Session detail with Phase tab (timeline, metadata, annotations) - Domain-oriented observability probes - Red Hat Hardened Image (distroless) Dockerfile, kustomize manifests, Makefile targets - 42 tests (adapters, mappers, hooks, observability, utilities) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Production overlay: oauth-proxy sidecar, Route with TLS, AUTH_MODE=oauth-proxy - CI: ambient-ui unit tests in unit-tests.yml (vitest, path-filtered) - Release: ambient-ui in prod-release-deploy build matrix and deploy map Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The PR review gate flagged the hardcoded fallback string as a possible secret. Use crypto.randomBytes for the non-SSO fallback instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jsell-rh
force-pushed
the
jsell/feat/ambient-ui
branch
from
edcdbca to
0951a8d
Compare
CI runs `npx vitest run --coverage` which needs an explicit provider configured since we use @vitest/coverage-istanbul, not the default v8. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The SDK is a file: dependency with dist/ gitignored. CI needs to build it before npm ci can resolve the ambient-sdk imports. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CodeQL flagged missing GITHUB_TOKEN permissions. Add minimal contents: read as required by GitHub Advanced Security. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Merge Queue Status
This pull request spent 22 seconds in the queue, including 3 seconds running CI. Required conditions to merge |
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
components/ambient-ui/— Next.js BFF ops console implementing the ambient-ui spec's walking skeletonunit-tests.yml, build inprod-release-deploy.yamlTest plan
cd components/ambient-ui && npm run build— 0 errors, 0 warningscd components/ambient-ui && npm run test— 42 tests passcd components/ambient-ui && npm run lint— 0 errorskubectl kustomize components/manifests/overlays/production/— renders ambient-ui deployment, service, routekubectl kustomize components/manifests/overlays/kind-local/— renders ambient-ui with localhost imagenpm run devon port 3001 with ambient-api-server running — project picker, fleet table, session detail all functional🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Build & Deployment