fix(runner): restore acp backend MCP tools as fallback when sidecar is absent#1607
Conversation
…s absent PR #1593 removed the acp backend MCP server (9 session management tools) when adding dynamic credential-aware MCP servers, but the ambient MCP sidecar only covers 5 of those 9 tools. Sessions without the sidecar (e.g. older CPs or missing MCP_IMAGE config) lost all session management tooling. Re-register the acp backend tools as a fallback when AMBIENT_MCP_URL is not set. When the sidecar IS present, its tools take precedence. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
✅ Deploy Preview for cheerful-kitten-f556a0 canceled.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesBackend MCP tool fallback
Possibly related PRs
🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
The scheduled-sessions E2E test for OOTB workflow name resolution depends on the backend fetching workflows from the GitHub API. In CI (Kind cluster), there's no GitHub token so the unauthenticated rate limit (60 req/hr) causes intermittent failures where the OOTB list comes back empty and the workflow dropdown falls back to "Custom workflow..." instead of showing "Fix a bug". Add cy.intercept stub for /api/workflows/ootb* with the expected bugfix workflow fixture data. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Merge Queue Status
This pull request spent 1 minute 4 seconds in the queue, including 10 seconds running CI. Required conditions to merge |
Summary
acpbackend MCP server (9 session management tools:acp_list_sessions,acp_get_session,acp_create_session,acp_stop_session,acp_send_message,acp_get_session_status,acp_restart_session,acp_list_workflows,acp_get_api_reference) when adding dynamic credential-aware MCP serversstop_session,restart_session,list_workflows, andget_api_referencehave no sidecar equivalentMCP_IMAGEconfig, orCP_TOKEN_URL/CPTokenPublicKeynot configured) lost all session management toolingacpbackend tools as a fallback whenAMBIENT_MCP_URLis not set. When the sidecar IS present, its tools take precedenceTest plan
acp_*tools appear when sidecar is absent🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Tests