Skip to content

fix: create parent directory before moving workflow clone #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guzalv wants to merge 3 commits into from
Closed

fix: create parent directory before moving workflow clone #1520

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11b2528
fix: create parent directory before moving workflow clone
guzalv May 7, 2026
481bd53
fix: also add mkdir -p in subpath-fallback branch of hydrate.sh
guzalv May 7, 2026
66f6f7e
fix: decouple repo/workflow cloning from S3 availability in hydrate.sh
guzalv May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions components/runners/ambient-runner/ambient_runner/endpoints/workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,12 @@ async def clone_workflow_at_runtime(
logger.warning(f"Subpath '{subpath}' not found, using entire repo")
if workflow_final.exists():
shutil.rmtree(workflow_final)
workflow_final.parent.mkdir(parents=True, exist_ok=True)
shutil.move(str(temp_dir), str(workflow_final))
else:
if workflow_final.exists():
shutil.rmtree(workflow_final)
workflow_final.parent.mkdir(parents=True, exist_ok=True)
shutil.move(str(temp_dir), str(workflow_final))

logger.info(f"Workflow '{workflow_name}' ready at {workflow_final}")
Expand Down
1 change: 1 addition & 0 deletions components/runners/state-sync/hydrate.sh
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ if [ -n "$ACTIVE_WORKFLOW_GIT_URL" ] && [ "$ACTIVE_WORKFLOW_GIT_URL" != "null" ]
fi
else
# No subpath - use entire repo
mkdir -p "$(dirname "$WORKFLOW_FINAL")"
mv "$WORKFLOW_TEMP" "$WORKFLOW_FINAL"
echo " ✓ Workflow ready at /workspace/workflows/${WORKFLOW_NAME}"
fi
Expand Down