fix: Resolve CI test failures#15
Merged
Merged
Conversation
Fix ImportError in test_server.py by updating imports to use the correct module and function names. Formatting functions were moved from server.py to formatters.py and don't have underscore prefixes. Changes: - Import formatting functions from mcp_acp.formatters instead of mcp_acp.server - Remove underscore prefixes from function names (_format_* -> format_*) - Update all test method calls to use public function names This resolves the CI import error: ImportError: cannot import name '_format_bulk_result' from 'mcp_acp.server' Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix test import errors that are causing CI to fail.
Changes
mcp_acp.formattersinstead ofmcp_acp.server_format_*→format_*)Root Cause
Formatting functions were moved from
server.pytoformatters.pyin a previous refactoring, but test imports were not updated. Functions also changed from private (_format_*) to public (format_*) names.Error Fixed
Testing
This is a separate PR from the caching optimizations (#14) to keep changes focused and avoid mixing unrelated fixes.
🤖 Generated with Claude Code