Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct URL case in go.mod #30

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Correct URL case in go.mod #30

merged 1 commit into from
Jul 19, 2024

Conversation

waits
Copy link
Contributor

@waits waits commented Jul 10, 2024

Performing go get (as specified in the readme) on this package fails because the module name in go.mod doesn't match the GitHub URL casing:

$ go get -u github.com/amatsagu/tempest
go: github.com/amatsagu/tempest@upgrade (v1.2.0) requires github.com/amatsagu/[email protected]: parsing go.mod:
	module declares its path as: github.com/Amatsagu/Tempest
	        but was required as: github.com/amatsagu/tempest

go get github.com/Amatsagu/Tempest works, but it is probably best if the module name matches the actual URL and the readme.

If this is merged the imports in example/ will need to be updated to match.

Performing `go get` on this package fails because the module name in `go.mod` doesn't match the GitHub URL casing:
```
$ go get -u github.com/amatsagu/tempest
go: github.com/amatsagu/tempest@upgrade (v1.2.0) requires github.com/amatsagu/[email protected]: parsing go.mod:
	module declares its path as: github.com/Amatsagu/Tempest
	        but was required as: github.com/amatsagu/tempest
```
@waits waits requested a review from amatsagu as a code owner July 10, 2024 21:33
Copy link
Owner

@amatsagu amatsagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I'll accept this but it's a bit weird.. I would assume it should work as github automatically translates uppercase/lowercase symbols in uri. It seems more like weird edge case, limitation of go get tool. Anyway, thanks.

@amatsagu amatsagu merged commit fc7b532 into amatsagu:master Jul 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants