-
-
Notifications
You must be signed in to change notification settings - Fork 576
First set of UI tweaks #3002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First set of UI tweaks #3002
Conversation
alvr/dashboard/src/dashboard/components/settings_controls/number.rs
Outdated
Show resolved
Hide resolved
alvr/dashboard/src/dashboard/components/settings_controls/number.rs
Outdated
Show resolved
Hide resolved
alvr/dashboard/src/dashboard/components/settings_controls/reset.rs
Outdated
Show resolved
Hide resolved
alvr/dashboard/src/dashboard/components/settings_controls/reset.rs
Outdated
Show resolved
Hide resolved
…ed values. Replaced hard coded frame corner radius with calculation.
… notice panel corner radius to match buttons.
|
Keep padding to 10 |
|
@Iemand005 you need to fix the code in number.rs or let me know if I should take care of it |
Co-Authored-By: Lasse Lauwerys <[email protected]>
|
@Iemand005 I squashed then added my changes as a separate commits |
|
Hey, my apologies for disappearing for a bit. I think I had made some changes but I'm not sure what was checked in or not. I merged what I had where I left off with the changes you made. I'll take a look at the current state and see if anything else needs to be improved. Thank you very much! |
|
@Iemand005 Can you explain what did you add extra since my last change? Also I would prefer to not to add more things to this PR. I think it was already in a good state and ready to be merged. if you have more changes I think you should do them in another PR. As a suggestion, for the next time, since I already squashed you commits, if you still had changes not pushed, squash all of you commits then rebase. This way we avoid nasty merge commits and interleaving your commits back into the history while I already squashed them. It makes it easier to review. |
|
It looks like I didn't really make any changes, I for some reason had outgoing commits and synced those but that code was already pushed. In the end only an import was moved: b864cce...6276869 Your code was great, the commits I made 2 days ago don't do anything and can be discarded. The branch should be reverted to b864cce My apologies for the confusion. Thank you and have a nice day! |
|
I think I'll take care of this since I'm here |







Fixes some of the UI design errors in ALVR Dashboard.
Before
After
Changes:
Let me know what else needs to be improved. Thank you very much!