Skip to content

Conversation

@Iemand005
Copy link
Contributor

Fixes some of the UI design errors in ALVR Dashboard.

Before

afbeelding

After

afbeelding

Changes:

  • Square reset buttons
  • Centered toggle buttons
  • Centered scroll bar
  • Removed odd margin above scroll bar's value display
  • Adjusted panel corner radius to make the margin in the rounding even with the buttons
  • Scrollbar value display drag speed set to linear

Let me know what else needs to be improved. Thank you very much!

@Iemand005
Copy link
Contributor Author

I extracted the hard coded values and updated the frames to respond to the padding setting. The corner radius of frames is also automatically calculated to match whatever the other values are set to.

Padding 10:

afbeelding afbeelding afbeelding

Padding 30:

afbeelding afbeelding afbeelding

Settings frame is updated to have the same padding and rounding as the other frames:

afbeelding

@zmerp
Copy link
Member

zmerp commented Aug 28, 2025

Keep padding to 10

@Iemand005 Iemand005 requested a review from zmerp September 12, 2025 22:25
@zmerp
Copy link
Member

zmerp commented Sep 13, 2025

@Iemand005 you need to fix the code in number.rs or let me know if I should take care of it

@zmerp
Copy link
Member

zmerp commented Oct 12, 2025

@Iemand005 I squashed then added my changes as a separate commits
@The-personified-devil the last commit is actually a fix for the last tooltip fix PR, were I broke some preset names

@Iemand005
Copy link
Contributor Author

Hey, my apologies for disappearing for a bit.

I think I had made some changes but I'm not sure what was checked in or not. I merged what I had where I left off with the changes you made.

I'll take a look at the current state and see if anything else needs to be improved.

Thank you very much!

@zmerp
Copy link
Member

zmerp commented Oct 15, 2025

@Iemand005 Can you explain what did you add extra since my last change?

Also I would prefer to not to add more things to this PR. I think it was already in a good state and ready to be merged. if you have more changes I think you should do them in another PR.

As a suggestion, for the next time, since I already squashed you commits, if you still had changes not pushed, squash all of you commits then rebase. This way we avoid nasty merge commits and interleaving your commits back into the history while I already squashed them. It makes it easier to review.

@Iemand005
Copy link
Contributor Author

It looks like I didn't really make any changes, I for some reason had outgoing commits and synced those but that code was already pushed.

In the end only an import was moved: b864cce...6276869

Your code was great, the commits I made 2 days ago don't do anything and can be discarded. The branch should be reverted to b864cce

My apologies for the confusion.

Thank you and have a nice day!

zmerp
zmerp previously approved these changes Oct 20, 2025
@zmerp
Copy link
Member

zmerp commented Oct 21, 2025

I think I'll take care of this since I'm here

@zmerp zmerp added this pull request to the merge queue Oct 23, 2025
Merged via the queue into alvr-org:master with commit a6af8c2 Oct 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants