refactor: xtask download/build, platform separation #2965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened pr for CI/CD, don't check the code yet |
The-personified-devil
force-pushed
the
xtask-refactor
branch
from
efc9036 to
ffae62c
Compare
|
huh? why was it force-pushed?... |
|
@The-personified-devil was it pushed by accident? |
|
i will revert changes for now, they don't seem to be changing anything?... (i could have done rebase/merge from master myself later, when i finished with this) |
Meister1593
force-pushed
the
xtask-refactor
branch
from
ffae62c to
efc9036
Compare
… reproducible builds are not possible yet
|
@Meister1593 Sorry, all the messing around with merge-queues made it so this had to be rebased and when github offered me a convenient button I just clicked that forgetting that that's really annoying for the local state of your repo (+ I didn't expect it would put me as the committer). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated download/build process as much as i could and added two more tasks (
download-server-deps,build-server-deps), and made all paths used for dependencies from prepare-deps static (meaning, you can reference them independently from each other).Also separated code for platforms in dependencies as it was getting quite cluttered...
Only lightly touched up code for windows, logic shouldn't be really changed (aside from same path usage as for linux), did not fully refactor it.
This greatly helps package managers on linux that are strict on fetch and build phases, though doesn't fully address it (they still need to build
alvr_xtaskbeforehand somehow).Also
alvr_launcherusescargo installwhich both fetches and buildscargo aboutat the same time (and cargo about by itself uses internet) - this needs cleaning up too, but it is a bit too much for one PR, will do it separately. For now focus is on actual server binaries.