Skip to content

Set sideEffects to CSS only + remove custom unused assets plugin #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MattIPv4 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Set sideEffects to CSS only + remove custom unused assets plugin #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0fde7b
Set sideEffects to CSS only
MattIPv4 Dec 9, 2025
4cd6325
Disable unused assets plugin
MattIPv4 Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"types": "tsc --noEmit"
},
"dependencies": {
"@alveusgg/data": "0.69.0",
"@alveusgg/data": "0.69.1-0-pre.610674a0072c44c904512733dd14ba0893ce9533",
"@headlessui/react": "^2.2.9",
"luxon": "^3.7.2",
"react": "^19.2.1",
Expand Down Expand Up @@ -81,6 +81,9 @@
"zip-webpack-plugin": "^4.0.3"
},
"main": "public/index.html",
"sideEffects": [
"**/*.css"
],
"browserslist": {
"production": [
">0.2%",
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

100 changes: 50 additions & 50 deletions webpack.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,58 +19,58 @@ const env = {
...(isDev && dotenv.config({ path: "./.env.development" }).parsed),
};

class UnusedAssetsPlugin {
apply(compiler: webpack.Compiler) {
if (compiler.options.mode && compiler.options.mode !== "production") return;
// class UnusedAssetsPlugin {
// apply(compiler: webpack.Compiler) {
// if (compiler.options.mode && compiler.options.mode !== "production") return;

compiler.hooks.compilation.tap(
"UnusedAssetsPlugin",
(compilation: webpack.Compilation) => {
compilation.hooks.processAssets.tap(
{
name: "UnusedAssetsPlugin",
stage: webpack.Compilation.PROCESS_ASSETS_STAGE_OPTIMIZE_TRANSFER,
},
() => {
// Get all JS source code
const jsSource = Object.entries(compilation.assets)
.filter(
([name]) => name.endsWith(".js") && !name.endsWith(".map"),
)
.map(([, source]) => source.source().toString())
.join("\n");
// compiler.hooks.compilation.tap(
// "UnusedAssetsPlugin",
// (compilation: webpack.Compilation) => {
// compilation.hooks.processAssets.tap(
// {
// name: "UnusedAssetsPlugin",
// stage: webpack.Compilation.PROCESS_ASSETS_STAGE_OPTIMIZE_TRANSFER,
// },
// () => {
// // Get all JS source code
// const jsSource = Object.entries(compilation.assets)
// .filter(
// ([name]) => name.endsWith(".js") && !name.endsWith(".map"),
// )
// .map(([, source]) => source.source().toString())
// .join("\n");

// Find all asset modules and check if they're referenced in the final JS
const unusedAssets = Array.from(compilation.modules)
.filter((module) => /^asset(\/.+)?$/.test(module.type))
.map((module) => module.buildInfo?.filename)
.filter(
(filename): filename is string =>
!!filename && !jsSource.includes(filename),
);
if (unusedAssets.length === 0) return;
// // Find all asset modules and check if they're referenced in the final JS
// const unusedAssets = Array.from(compilation.modules)
// .filter((module) => /^asset(\/.+)?$/.test(module.type))
// .map((module) => module.buildInfo?.filename)
// .filter(
// (filename): filename is string =>
// !!filename && !jsSource.includes(filename),
// );
// if (unusedAssets.length === 0) return;

// Remove unused assets from the compilation
unusedAssets.forEach((asset) => {
compilation.deleteAsset(asset);
});
console.warn(
[
"",
`UnusedAssetsPlugin: Removed ${unusedAssets.length} unused assets:`,
...unusedAssets.slice(0, 10).map((asset) => ` - ${asset}`),
...(unusedAssets.length > 10
? [` ...and ${unusedAssets.length - 10} more`]
: []),
"",
].join("\n"),
);
},
);
},
);
}
}
// // Remove unused assets from the compilation
// unusedAssets.forEach((asset) => {
// compilation.deleteAsset(asset);
// });
// console.warn(
// [
// "",
// `UnusedAssetsPlugin: Removed ${unusedAssets.length} unused assets:`,
// ...unusedAssets.slice(0, 10).map((asset) => ` - ${asset}`),
// ...(unusedAssets.length > 10
// ? [` ...and ${unusedAssets.length - 10} more`]
// : []),
// "",
// ].join("\n"),
// );
// },
// );
// },
// );
// }
// }
Comment thread
MattIPv4 marked this conversation as resolved.

const getTypeScriptLoader = () => ({
loader: "ts-loader",
Expand Down Expand Up @@ -182,7 +182,7 @@ const config: webpack.Configuration = {
// Enforce type checking on a separate process
new ForkTsCheckerWebpackPlugin(),
// Remove any unused assets after code optimization
new UnusedAssetsPlugin(),
// new UnusedAssetsPlugin(),
// Enable react hot reloading in development
isDev &&
new ReactRefreshWebpackPlugin({
Expand Down