Skip to content

responsive for dark and light mode , for all devices scroll bar added #141

Open
Khushee21 wants to merge 1 commit intoalvarotorrestx:devfrom
Khushee21:scrollbar
Open

responsive for dark and light mode , for all devices scroll bar added #141
Khushee21 wants to merge 1 commit intoalvarotorrestx:devfrom
Khushee21:scrollbar

Conversation

@Khushee21
Copy link

No description provided.

Copy link
Owner

@alvarotorrestx alvarotorrestx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the style you created. There's just a lot of unnecessary additions and changes.

Please read each comment and adapt.

Thank you 😊

"react-markdown": "^10.1.0",
"react-router-dom": "^6.23.1",
"remark-gfm": "^4.0.1",
"tailwind-scrollbar": "^4.0.2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You installed this but you didn't use it. Please uninstall.

Comment on lines +1304 to +1309
"node_modules/@types/prismjs": {
"version": "1.26.5",
"resolved": "https://registry.npmjs.org/@types/prismjs/-/prismjs-1.26.5.tgz",
"integrity": "sha512-AUZTa7hQ2KY5L7AmtSiqxlhWxb4ina0yd8hNbl4TWuqnv/pFP0nDMb3YrfSBf4hJVGLh2YEIBfKaBW/9UEl6IQ==",
"license": "MIT"
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same goes for this, please uninstall.

Comment on lines +1897 to +1905
"node_modules/clsx": {
"version": "2.1.1",
"resolved": "https://registry.npmjs.org/clsx/-/clsx-2.1.1.tgz",
"integrity": "sha512-eYm0QWBtUrBWZWG0d386OGAw16Z995PiOVo2B7bjWSbHedGl5e0ZWaq65kOGgUSNesEIDkB9ISbTg/JK9dhCZA==",
"license": "MIT",
"engines": {
"node": ">=6"
}
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same goes for this, please uninstall.

Comment on lines +5588 to +5600
"node_modules/prism-react-renderer": {
"version": "2.4.1",
"resolved": "https://registry.npmjs.org/prism-react-renderer/-/prism-react-renderer-2.4.1.tgz",
"integrity": "sha512-ey8Ls/+Di31eqzUxC46h8MksNuGx/n0AAC8uKpwFau4RPDYLuE3EXTp8N8G2vX2N7UC/+IXeNUnlWBGGcAG+Ig==",
"license": "MIT",
"dependencies": {
"@types/prismjs": "^1.26.0",
"clsx": "^2.0.0"
},
"peerDependencies": {
"react": ">=16.0.0"
}
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same goes for this, please uninstall.

Comment on lines +6478 to +6492
"node_modules/tailwind-scrollbar": {
"version": "4.0.2",
"resolved": "https://registry.npmjs.org/tailwind-scrollbar/-/tailwind-scrollbar-4.0.2.tgz",
"integrity": "sha512-wAQiIxAPqk0MNTPptVe/xoyWi27y+NRGnTwvn4PQnbvB9kp8QUBiGl/wsfoVBHnQxTmhXJSNt9NHTmcz9EivFA==",
"license": "MIT",
"dependencies": {
"prism-react-renderer": "^2.4.1"
},
"engines": {
"node": ">=12.13.0"
},
"peerDependencies": {
"tailwindcss": "4.x"
}
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same goes for this, please uninstall.

@@ -1,5 +1,5 @@
import axios from 'axios';
const BASE_URL = 'http://localhost:5000';
const BASE_URL = 'http://localhost:3000';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should remain port 5000.
This is the port our backend server uses.

Comment on lines +51 to +52
<div className="h-screen overflow-y-auto scrollbar-thin scrollbar-thumb-base-content scrollbar-track-base-200 dark:scrollbar-thumb-base-100 dark:scrollbar-track-base-300">
{/*responsive scroll bar added*/}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep the scrollbar style changes just to main the scrollbar only, not overflow scrolling for now. so please remove.


return (
<div className="max-w-[90%] lg:max-w-4xl mx-auto p-6 bg-base-100 rounded-lg shadow-md">
{/*Add scroll bar here if needed*/}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment.

},
plugins: [
require("daisyui"),
require("tailwind-scrollbar"),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same goes for this as earlier, please uninstall.

Comment on lines +11 to +16
{/*you can add if needed for check res i have added this*/}
// app.get('/' , (req, res)=>{
// res.send('Dev Connecct to server')
// console.log('Dev Coonect to server');
// })

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants