Implemented a countdown timer with automatic redirection to the login…#121
Open
kamome-run wants to merge 2 commits intoalvarotorrestx:devfrom
Open
Implemented a countdown timer with automatic redirection to the login…#121kamome-run wants to merge 2 commits intoalvarotorrestx:devfrom
kamome-run wants to merge 2 commits intoalvarotorrestx:devfrom
Conversation
alvarotorrestx
requested changes
May 9, 2025
Owner
alvarotorrestx
left a comment
There was a problem hiding this comment.
Vey nice implementation! There's just some minor changes and it's ready for merging! Thanks so much! 😀
Comment on lines
+832
to
+834
| <div className="countdown-timer"> | ||
| {isCountdownTimer && <CountdownTimer className="text-green-600 text-4xl" />} | ||
| </div> |
Owner
There was a problem hiding this comment.
Let's have this replace lines 204 - 209 that you currently have.
Basically replacing: <p className="text-md mt-1"> <Link to="/login" className="link link-primary"> Click here to log in </Link>{" "} and get started! </p>
That way the new message is just your countdown and redirects inside of the same block as the success message.
| message: successMessage, | ||
| show: showSuccessToast, | ||
| showSuccess, | ||
| //showSuccess, |
Owner
There was a problem hiding this comment.
Please uncomment this as we have had someone recently add a feature with the success on login page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented functions