refactor: new LayoutTree module to improve on ui headaches #427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at introducing a ui that is more easy to work with.
It is now composable via functions, and simplifies the UI code to just:
The styling, particularly in the
screen
-module needs fixing.Spans do wrap to new lines, breaking the editor (it assumes 1 item = 1 line)
Spans are truncated if too long, we should word/char-wrap instead. Perhaps feeding every single char to "layout" could work.
There's a lot of allocations going on, one way to amend this could be to look at removing the 'static lifetime from
app.layout_tree
. Since it is only used once per frame and cleared after.The tui_prompt dependency should be easier to get rid of now. Eventually, we may get rid of Ratatui as well.