Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disable avoid_hardcoded_color lint if it's a test file #83

Merged
merged 2 commits into from
Dec 24, 2024
Merged

feat: disable avoid_hardcoded_color lint if it's a test file #83

merged 2 commits into from
Dec 24, 2024
+108 −4

Conversation

riscait
Copy link
Member

@riscait riscait commented Dec 23, 2024 •
edited
Loading

🔗 Related Issues

🙌 What's Done

  • create a files_utiles.dart
  • add a isTestFile method

✍️ What's Not Done

🖼️ Image Differences

Before After
image image

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

@riscait riscait marked this pull request as ready for review December 23, 2024 12:27
@riscait riscait requested a review from a team as a code owner December 23, 2024 12:27
@riscait riscait requested review from naipaka and removed request for a team December 23, 2024 12:27
naipaka
naipaka approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@naipaka naipaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!🙏

badge
It might be reasonable to check that no warnings appear in avoid_hardcoded_color_test.dart, just as in avoid_hardcoded_japanese_test.dart.

riscait
riscait commented Dec 24, 2024
View reviewed changes
packages/altive_lints/example/test/avoid_hardcoded_japanese.dart
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed _test from the filename because it does not confirm the test directory if _test is added to the filename!

@riscait
Copy link
Member Author

riscait commented Dec 24, 2024

It might be reasonable to check that no warnings appear in avoid_hardcoded_color_test.dart, just as in avoid_hardcoded_japanese_test.dart.

Thanks! I've added test files🚀

@riscait riscait merged commit 6003c83 into main Dec 24, 2024
1 check passed
@riscait riscait deleted the #82-disable-avoid_hardcoded_color-lint-in-test branch December 24, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naipaka naipaka naipaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable avoid_hardcoded_color lint if it's a test file
2 participants
@riscait @naipaka