Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable specify_nonobvious_local_variable_types to avoid conflicts #80

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

naipaka
Copy link
Contributor

@naipaka naipaka commented Dec 16, 2024

🙌 What's Done

  • Disable specify_nonobvious_local_variable_types to avoid conflicts

After upgrading to Flutter 3.27.0, warnings for specify_nonobvious_local_variable_types—enabled since version 3.6—started appearing.
As noted here, since we are using omit_local_variable_types, we cannot adopt specify_nonobvious_local_variable_types.
Therefore, we disabled it.

✍️ What's Not Done

  • None

🖼️ Image Differences

Before After
image image

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

@naipaka naipaka requested a review from a team as a code owner December 16, 2024 07:55
@naipaka naipaka requested review from k-nkmr and removed request for a team December 16, 2024 07:55
Copy link
Member

@riscait riscait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you🚀

@riscait riscait merged commit cc54fcc into main Dec 16, 2024
1 check passed
@riscait riscait deleted the specify-nonobvious-local-variable-types-exclusion branch December 16, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants