Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Exclude Colors.transparent from the target of avoid_hardcoded_color #63

Merged
merged 2 commits into from
Oct 7, 2024
Merged

fix: Exclude Colors.transparent from the target of avoid_hardcoded_color #63

merged 2 commits into from
Oct 7, 2024

Conversation

boywithdv
Copy link
Contributor

@boywithdv boywithdv commented Oct 7, 2024 •
edited
Loading

🔗 Related Issues

🙌 What's Done

  • Exclude Colors.transparent from the target of avoid_hardcoded_color

✍️ What's Not Done

🖼️ Image Differences

スクリーンショット 2024-10-07 12 06 07

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

@boywithdv boywithdv changed the title fix: Colors.transparent from the target of avoid_hardcoded_color fix: Exclude Colors.transparent from the target of Avoid_hardcoded_color Oct 7, 2024
@boywithdv boywithdv changed the title fix: Exclude Colors.transparent from the target of Avoid_hardcoded_color fix: Exclude Colors.transparent from the target of avoid_hardcoded_color Oct 7, 2024
@boywithdv boywithdv changed the title fix: Exclude Colors.transparent from the target of avoid_hardcoded_color fix: Exclude colors.transparent from the target of avoid_hardcoded_color Oct 7, 2024
@boywithdv boywithdv changed the title fix: Exclude colors.transparent from the target of avoid_hardcoded_color fix: Exclude Colors.transparent from the target of avoid_hardcoded_color Oct 7, 2024
@boywithdv boywithdv marked this pull request as ready for review October 7, 2024 03:46
@boywithdv boywithdv requested a review from a team as a code owner October 7, 2024 03:46
@boywithdv boywithdv requested review from riscait and removed request for a team October 7, 2024 03:46
riscait
riscait approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@riscait riscait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

badge
It may be more helpful to add the following sentence to the description of avoid_hardcoded_colour in the README.
"However, Colours.transparent can be used."

@boywithdv boywithdv merged commit f1a1f5f into main Oct 7, 2024
1 check passed
@boywithdv boywithdv deleted the 59-transparent-hardcode branch October 7, 2024 04:40
@naipaka naipaka mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riscait riscait riscait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exclude Colors.transparent from the target of avoid_hardcoded_color
2 participants
@boywithdv @riscait