fix: Add stack to avoid_single_child #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riscait
approved these changes
Sep 3, 2024
Comment on lines
47
to
53
| Text('World'), | ||
| ], | ||
| ), | ||
| // expect_lint: avoid_single_child | ||
| SliverList.list( | ||
| children: const [ | ||
| Text('World'), | ||
| Text('Hello'), |
There was a problem hiding this comment.
Why did you swap these two strings?
Both Hello looks good.
There was a problem hiding this comment.
I made this change because I believe the text should be alternated, like "Hello" and "World," similar to how you would arrange them in a Column or Row. Specifically, I placed the Stack widget under the Wrap widget, so I wrote "Hello," and since the ListView widget is under the Stack, I decided "World" should be written to alternate the text.
The following commit adds a fix to make both Hello.
a21c8a6
There was a problem hiding this comment.
I see, you thought about what would happen if it appeared on the screen!
Please comment why next time.
Co-authored-by: Ryunosuke Muramatsu <[email protected]>
riscait
reviewed
Sep 3, 2024
Co-authored-by: Ryunosuke Muramatsu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
🙌 What's Done
✍️ What's Not Done
🖼️ Image Differences
🤼 Desired Review Method
Note
It is possible that a reviewer's will may cause a method to be implemented that is not selected.
📝 Additional Notes
Pre-launch Checklist