feat: Set up custom lint #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naipaka
commented
Jul 28, 2024
There was a problem hiding this comment.
I have added a workflow to run tests for analyze and custom_lint using GitHub Actions.
Comment on lines
+9
to
+10
| # Unnecessary if not localizing or not using Japanese. | ||
| # - avoid_hardcoded_japanese: false |
There was a problem hiding this comment.
I have provided an example of rule exclusion.
Comment on lines
+9
to
+10
| List<LintRule> getLintRules(CustomLintConfigs configs) => [ | ||
| const AvoidHardcodedJapanese(), |
There was a problem hiding this comment.
As an example, I have defined custom lint rules that have already been implemented in another repository.
naipaka
commented
Jul 28, 2024
There was a problem hiding this comment.
Since the test does not start from the main function, the test code is placed in the lint_test directory instead of the test directory. I referred to other repositories that use custom_lint.
riscait
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
🙌 What's Done
✍️ What's Not Done
🖼️ Image Differences
🤼 Desired Review Method
Note
It is possible that a reviewer's will may cause a method to be implemented that is not selected.
📝 Additional Notes
Pre-launch Checklist