The code changes primarily involve the addition of a private field `_… #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isInitialized` and a private property `_valueOrThrow` in various structs. The `_isInitialized` field is used to check if the struct has been initialized, and the `_valueOrThrow` property returns the value if the struct is initialized, otherwise it throws an `InvalidDomainValueException`. This ensures that a value has been properly initialized before it can be accessed. All methods and properties that previously directly accessed the `_value` field now use the `_valueOrThrow` property. This ensures that an exception is thrown if the struct is not properly initialized before its value is accessed. The `Default` property and its usage have been removed from several classes and test classes. This suggests that the concept of a "default" value for these types has been removed or refactored. The `SwaggerTypeHelper` class has been updated to remove the `Default` property from the `OpenApiSchema` objects it creates for various types. This suggests that these types no longer have a default value in the context of OpenAPI/Swagger. A new class `StringLengthAttribute` was added, which is a validation attribute used to assert that a string property, field or parameter does not exceed a maximum length. The changes are spread across multiple files including `Executor.cs`, `Constants.cs`, `GeneratorData.cs`, `MethodGeneratorHelper.cs`, `AsciiString.cs`, `GDay.cs`, `GMonth.cs`, `GMonthDay.cs`, `GYear.cs`, `GYearMonth.cs`, `NegativeInteger.cs`, `NonEmptyString.cs`, `NonNegativeInteger.cs`, `NonPositiveInteger.cs`, `PositiveInteger.cs`, `IDomainValue.cs`, `DomainPrimitiveGeneratorTest` class, `CharValue` and `DateOnlyValue` structs, `SwaggerTypeHelper` class, `IntOfIntValue` and `IntValue` structs, `StringValue` and `TimeOnlyValue` classes, `TimeSpanValue` and `UShortValue` structs, `IntValue` and `LongValue` structs, and `NonPositiveIntegerTests.cs` and `PositiveIntegerTests.cs` files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Defaultproperty and its usage have been removed.The
SwaggerTypeHelperclass has been updated to remove theDefaultproperty from theOpenApiSchemaobjects it creates for various types.A new class
StringLengthAttributewas added, which is a validation attribute used to assert that a string property, field or parameter does not exceed a maximum length.