Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(syntax.json): Move language .move #255

Merged
merged 6 commits into from
Jan 2, 2025
Merged

Conversation

netpoe
Copy link
Contributor

@netpoe netpoe commented Dec 22, 2024

New Language Definition Contribution

Thank you for contributing a new language definition! Please follow the guidelines below to ensure that your contribution can be easily reviewed and integrated into the project.

Description

syntax.json file update for the Move language.

As defined in https://raw.githubusercontent.com/github/linguist/master/lib/linguist/languages.yml

Language Name: (e.g., Python, JavaScript)

Move

Fixes # (issue number, if applicable)

Checklist for Adding a New Language

Before submitting your pull request, please ensure the following requirements are met:

  • [x ] I have added the language to syntax.json with the language name matching that in GitHub's Linguist languages.yml file.
  • [x ] I have added sample code to test_new.diff and test_closed.diff.
  • [ x] I have added issue creation and closure tests to test_todo_parser.py. The tests should check that the ace_mode of the issue matches that specified in the languages.yml file. If existing checks for that ace_mode exists, I have incremented them instead.
  • [x ] I have updated README.md to add the language.
  • I have run and verified all tests.

Thank You

We appreciate your time and effort in improving this project!

@netpoe
Copy link
Contributor Author

netpoe commented Dec 22, 2024

@alstr I ran python -m unittest but it is taking forever, is this normal?

Anything else I may be missing?

I don't see solidity in any of test_todo_parser.py cases, but it's still on master. Is this expected?

@alstr
Copy link
Owner

alstr commented Dec 24, 2024

Thanks for the contribution! Everything looks okay, just the test should check for text, not move, as this is based on the ace_mode of the language as defined in languages.yml.

Solidity should be in the diff files:

+++ b/Counter.sol

But like Move, the ace_mode is text, so the tests are subsumed under that.

@netpoe
Copy link
Contributor Author

netpoe commented Dec 28, 2024

Thanks for the contribution! Everything looks okay, just the test should check for text, not move, as this is based on the ace_mode of the language as defined in languages.yml.

Solidity should be in the diff files:

+++ b/Counter.sol

But like Move, the ace_mode is text, so the tests are subsumed under that.

Updated!

@alstr
Copy link
Owner

alstr commented Dec 30, 2024

Thanks, that seems good.

@rgalonso, is the test failing here because of an issue accessing the diff file?

https://github.com/alstr/todo-to-issue-action/actions/runs/12524278755/job/34987937879?pr=255

@rgalonso
Copy link
Contributor

@alstr, patch is getting tripped up because the diff file is not in the correct format.

@netpoe, you're missing a newline at the end of the file. Just add that and I think you'll be fine.

@alstr alstr merged commit c5294a6 into alstr:master Jan 2, 2025
1 check passed
@alstr
Copy link
Owner

alstr commented Jan 2, 2025

Thanks @rgalonso that seemed to fix things.

@alstr
Copy link
Owner

alstr commented Jan 2, 2025

Also, @netpoe, I'm assuming this is the line causing the delay in the tests when you run them:

https://github.com/alstr/todo-to-issue-action/blob/master/tests/test_process_diff.py#L74

You can disable it if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants