-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(syntax.json): Move language .move #255
Conversation
@alstr I ran Anything else I may be missing? I don't see |
Thanks for the contribution! Everything looks okay, just the test should check for Solidity should be in the diff files: todo-to-issue-action/tests/test_new.diff Line 544 in 9733933
But like Move, the |
Updated! |
Thanks, that seems good. @rgalonso, is the test failing here because of an issue accessing the diff file? https://github.com/alstr/todo-to-issue-action/actions/runs/12524278755/job/34987937879?pr=255 |
Thanks @rgalonso that seemed to fix things. |
Also, @netpoe, I'm assuming this is the line causing the delay in the tests when you run them: https://github.com/alstr/todo-to-issue-action/blob/master/tests/test_process_diff.py#L74 You can disable it if you wish. |
New Language Definition Contribution
Thank you for contributing a new language definition! Please follow the guidelines below to ensure that your contribution can be easily reviewed and integrated into the project.
Description
syntax.json
file update for the Move language.As defined in https://raw.githubusercontent.com/github/linguist/master/lib/linguist/languages.yml
Language Name: (e.g., Python, JavaScript)
Move
Fixes # (issue number, if applicable)
Checklist for Adding a New Language
Before submitting your pull request, please ensure the following requirements are met:
syntax.json
with the language name matching that in GitHub's Linguistlanguages.yml
file.test_new.diff
andtest_closed.diff
.test_todo_parser.py
. The tests should check that theace_mode
of the issue matches that specified in thelanguages.yml
file. If existing checks for thatace_mode
exists, I have incremented them instead.README.md
to add the language.Thank You
We appreciate your time and effort in improving this project!