Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TOML Support #214

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Added TOML Support #214

merged 4 commits into from
Oct 14, 2024

Conversation

aleexharris
Copy link
Contributor

@aleexharris aleexharris commented Oct 11, 2024

New Language Definition Contribution

Description

Language Name: TOML

Tests based quite heavily on the YAML tests.

Checklist for Adding a New Language

  • I have added the language to syntax.json with the language name matching that in GitHub's Linguist languages.yml file.
  • I have added sample code to test_new.diff and test_closed.diff.
  • I have added issue creation and closure tests to test_todo_parser.py. The tests should check that the ace_mode of the issue matches that specified in the languages.yml file. If existing checks for that ace_mode exists, I have incremented them instead.
  • I have updated README.md to add the language.
  • I have run and verified all tests.

NOTE: I couldn't get the test suite to run for me (even the clean fork) and I tried a couple different versions of Python. Maybe worth adding to the documentation more detail around this.

@aleexharris aleexharris changed the title Add TOML Support Added TOML Support Oct 12, 2024
@alstr alstr merged commit 771af35 into alstr:master Oct 14, 2024
1 check passed
@alstr
Copy link
Owner

alstr commented Oct 14, 2024

Thanks for the submission.

All the tests run fine here. You should just need to do:

python -m pip install --upgrade pip
# Make sure pytest is installed
pip install -r requirements.txt
python -m unittest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants