Tidy func test fixtures code #4325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leohemsted
force-pushed
the
tidy-func-test-fixtures-code
branch
3 times, most recently
from
555cb0e to
77d2b68
Compare
spatel033
reviewed
Jan 9, 2025
spatel033
approved these changes
Jan 9, 2025
enforces separation of concerns a bit, and will make the inner function easier to test independently i've tested this manually - the only differences between the old env vars file and the new one are: * new list is not ordered and doesn't have whitespace between sections * new list wraps _everything_ in single quotes. This could be an issue if an environment variable contains a single quote itself!
one test for the outer function, ignoring all fixtures - only concerned with "is the env var file well formed?" and "are things put in ssm correctly?"" one test for the inner function, ignoring ssm/etc - concerned with "are we creating db objects sensibly in an idempotent manner?" and "are we returning the correct things for environment variables?"
the idempotency is more about making sure fixtures can be applied to the same database multiple times
a bit cleaner and simpler than bit-by-bit string manipulation
leohemsted
force-pushed
the
tidy-func-test-fixtures-code
branch
from
77d2b68 to
ba97077
Compare
spatel033
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
objective:
split functional_test_fixtures into two concerns:
rationale:
this is really really best viewed commit-by-commit