Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate unsubscribe requests #4304

Conversation

BlessedDev
Copy link
Contributor

@BlessedDev BlessedDev commented Dec 10, 2024

This PR prevents duplicate unsubscribe requests.

A previously mereged PR was reverted because functional tests had to be updated first.

Reverts #4299

@BlessedDev BlessedDev marked this pull request as ready for review December 10, 2024 17:14
Copy link
Contributor

@CrystalPea CrystalPea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work - one comment - we could make the fixture a bit terser I think

tests/app/db.py Outdated Show resolved Hide resolved
@BlessedDev BlessedDev force-pushed the revert-4299-revert-4298-handling_duplicate_unsubscribe_requests branch 2 times, most recently from ca68cd0 to b48bca7 Compare December 12, 2024 12:17
BlessedDev and others added 2 commits January 6, 2025 10:27
 The earlier changes to prevent duplicate unsubscribe requests were reverted in order to
 update the functional tests for the unsubscribe request journey.
 This is a redeployment of those changes.
@BlessedDev BlessedDev force-pushed the revert-4299-revert-4298-handling_duplicate_unsubscribe_requests branch from 591f36a to 151a645 Compare January 6, 2025 10:27
@BlessedDev BlessedDev merged commit dabcfa9 into main Jan 6, 2025
3 checks passed
@BlessedDev BlessedDev deleted the revert-4299-revert-4298-handling_duplicate_unsubscribe_requests branch January 6, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants